Bug fixes #280

Xenofic · 2022-09-10T12:41:03Z

Description
Fixed many bugs in the main branch i'll list them here

Fixed the now playing thumbnails for soundcloud
Fixed uri not showing up for other platforms like spotify and soundcloud
Fixed the error data.Channel being null
Fixed autocompletion bug input as the value

Signed-off-by: NotAditya <[email protected]>

LucasB25 · 2022-09-10T13:54:00Z

bug fix ? #273
bug fix ? #276
Errors have been corrected here? if so what? #225

Xenofic · 2022-09-10T15:28:23Z

This fix doesn't contains #225 issues that would be fixed on the next pr this issue fixed #273 and also #276 and some more issues which weren't reported till now and i have seen people asking help in the support server so there's a lot of bug fixes this also includes this one you were asking about today in the support channel

TypeError: Cannot read properties of null (reading 'Channel')
    at module.exports (/home/pi/panaisv14/src/events/Lavalink/trackStart.js:38:22)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) Promise {
  <rejected> TypeError: Cannot read properties of null (reading 'Channel')
      at module.exports (/home/pi/panaisv14/src/events/Lavalink/trackStart.js:38:22)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
}

LucasB25 · 2022-09-10T15:35:22Z

I check all check be correct is there anything else added in the query where I can now accept it?

Xenofic · 2022-09-10T15:39:18Z

Accept it

LucasB25 · 2022-09-10T15:48:55Z

I just saw but you made some changes on slashs command but not the message commands, an oversight?

LucasB25 · 2022-09-10T15:52:22Z

DiscordAPIError[50035]: Invalid Form Body
21[APPLICATION_COMMANDS_DUPLICATE_NAME]: Application command names must be unique
    at SequentialHandler.runRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:287:15)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async SequentialHandler.queueRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:99:14)
    at async REST.request (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/REST.cjs:52:22)
    at async /home/XXX/lavamusic/src/handlers/slashCommand.js:52:7 {
  rawError: {
    code: 50035,
    errors: { '21': [Object] },
    message: 'Invalid Form Body'
  },
  code: 50035,
  status: 400,
  method: 'PUT',
  url: 'https://discord.com/api/v10/applications/707627135577358417/commands',
  requestBody: {
    files: undefined,
    json: [
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object]
    ]
  }
}

Xenofic · 2022-09-10T16:15:00Z

DiscordAPIError[50035]: Invalid Form Body
21[APPLICATION_COMMANDS_DUPLICATE_NAME]: Application command names must be unique
    at SequentialHandler.runRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:287:15)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async SequentialHandler.queueRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:99:14)
    at async REST.request (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/REST.cjs:52:22)
    at async /home/XXX/lavamusic/src/handlers/slashCommand.js:52:7 {
  rawError: {
    code: 50035,
    errors: { '21': [Object] },
    message: 'Invalid Form Body'
  },
  code: 50035,
  status: 400,
  method: 'PUT',
  url: 'https://discord.com/api/v10/applications/707627135577358417/commands',
  requestBody: {
    files: undefined,
    json: [
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object], [Object], [Object],
      [Object], [Object]
    ]
  }
}

Is this from my commits? I didn't change the name field for the play command check my dev branch it doesn't includes similar names

Xenofic · 2022-09-10T16:15:34Z

I just saw but you made some changes on slashs command but not the message commands, an oversight?

Well only made on play command and did on both other bugs were on emitters

LucasB25 · 2022-09-10T16:16:42Z

Is this from my commits? I didn't change the name field for the play command check my dev branch it doesn't includes similar names

yes it comes from your clerk before setting it up I do checks and this concern did not exist before the addition of your commit

Xenofic · 2022-09-10T16:20:06Z

But i don't find any conflicts in my part of the branch that has similar names?

Xenofic · 2022-09-10T16:20:34Z

Can you try recloning my fork (dev branch) and try again

LucasB25 · 2022-09-10T16:23:39Z

it’s me I didn’t say anything

on the other hand there is really a mistake
Oops! Error: 503 Service Unavailable

Xenofic · 2022-09-10T16:28:30Z

So that issue was from your side right?

Xenofic · 2022-09-10T16:28:48Z

Also 503? I want see a full screenshot

LucasB25 · 2022-09-10T16:32:03Z

So that issue was from your side right?

yes

LucasB25 · 2022-09-10T16:35:30Z

Also 503? I want see a full screenshot

there is nothing but that

Xenofic · 2022-09-11T12:03:29Z

the function occurances has it i'll have to change it for all of them it seems you probably have a different setup for the bot anyways i'll do it and push again and then try

Xenofic · 2022-09-11T12:04:42Z

@PandaIN95 you can retry now

PandaIN95 · 2022-09-11T12:13:20Z

@NotAditya69 still same
TypeError: Cannot read properties of null (reading 'identifier')
at trackStartEventHandler (/home/ubuntu/test2/lavamusic/src/utils/functions.js:198:19)
at module.exports (/home/ubuntu/test2/lavamusic/src/events/Lavalink/trackStart.js:40:13)
at processTicksAndRejections (node:internal/process/task_queues:96:5)

this bot is not destroying the player on right click disconnect in lavalink the player is getting paused

Xenofic · 2022-09-11T12:14:12Z

how can that still be null what? can you send me the snippet here

Xenofic · 2022-09-11T12:21:10Z

Desktop.2022.09.11.-.17.47.55.01.mp4

Works perfectly

LucasB25 · 2022-09-11T12:54:30Z

DiscordAPIError[10008]: Unknown Message
    at SequentialHandler.runRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:287:15)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async SequentialHandler.queueRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:99:14)
    at async REST.request (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/REST.cjs:52:22)
    at async MessageManager.delete (/home/XXX/lavamusic/node_modules/discord.js/src/managers/MessageManager.js:245:5)
    at async Message.delete (/home/XXX/lavamusic/node_modules/discord.js/src/structures/Message.js:767:5)
    at async Object.setNowplayingMessage (/home/XXX/lavamusic/src/structures/Lavamusic.js:36:11)
    at async module.exports (/home/XXX/lavamusic/src/events/Lavalink/trackStart.js:90:3) {
  rawError: { message: 'Unknown Message', code: 10008 },
  code: 10008,
  status: 404,
  method: 'DELETE',
  url: 'https://discord.com/api/v10/channels/1018438176286724110/messages/1018470209666961408',
  requestBody: { files: undefined, json: undefined }
} Promise {
  <rejected> DiscordAPIError[10008]: Unknown Message
      at SequentialHandler.runRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:287:15)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async SequentialHandler.queueRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:99:14)
      at async REST.request (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/REST.cjs:52:22)
      at async MessageManager.delete (/home/XXX/lavamusic/node_modules/discord.js/src/managers/MessageManager.js:245:5)
      at async Message.delete (/home/XXX/lavamusic/node_modules/discord.js/src/structures/Message.js:767:5)
      at async Object.setNowplayingMessage (/home/XXX/lavamusic/src/structures/Lavamusic.js:36:11)
      at async module.exports (/home/XXX/lavamusic/src/events/Lavalink/trackStart.js:90:3) {
    rawError: { message: 'Unknown Message', code: 10008 },
    code: 10008,
    status: 404,
    method: 'DELETE',
    url: 'https://discord.com/api/v10/channels/1018438176286724110/messages/1018470209666961408',
    requestBody: { files: undefined, json: undefined }
  }
}

That's a unknown message error you can safely ignore it it's always catched by the exceptions these appears whenever a message is to be edited/deleted but the message doesn't exists not a big deal that's completely random

it spam a lot so it’s som importance

PandaIN95 · 2022-09-11T13:06:53Z

2022-09-11.18-33-42.mp4

im not any errors in console now but still the same

Xenofic · 2022-09-11T14:33:21Z

DiscordAPIError[10008]: Unknown Message
    at SequentialHandler.runRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:287:15)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async SequentialHandler.queueRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:99:14)
    at async REST.request (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/REST.cjs:52:22)
    at async MessageManager.delete (/home/XXX/lavamusic/node_modules/discord.js/src/managers/MessageManager.js:245:5)
    at async Message.delete (/home/XXX/lavamusic/node_modules/discord.js/src/structures/Message.js:767:5)
    at async Object.setNowplayingMessage (/home/XXX/lavamusic/src/structures/Lavamusic.js:36:11)
    at async module.exports (/home/XXX/lavamusic/src/events/Lavalink/trackStart.js:90:3) {
  rawError: { message: 'Unknown Message', code: 10008 },
  code: 10008,
  status: 404,
  method: 'DELETE',
  url: 'https://discord.com/api/v10/channels/1018438176286724110/messages/1018470209666961408',
  requestBody: { files: undefined, json: undefined }
} Promise {
  <rejected> DiscordAPIError[10008]: Unknown Message
      at SequentialHandler.runRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:287:15)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async SequentialHandler.queueRequest (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/handlers/SequentialHandler.cjs:99:14)
      at async REST.request (/home/XXX/lavamusic/node_modules/@discordjs/rest/dist/lib/REST.cjs:52:22)
      at async MessageManager.delete (/home/XXX/lavamusic/node_modules/discord.js/src/managers/MessageManager.js:245:5)
      at async Message.delete (/home/XXX/lavamusic/node_modules/discord.js/src/structures/Message.js:767:5)
      at async Object.setNowplayingMessage (/home/XXX/lavamusic/src/structures/Lavamusic.js:36:11)
      at async module.exports (/home/XXX/lavamusic/src/events/Lavalink/trackStart.js:90:3) {
    rawError: { message: 'Unknown Message', code: 10008 },
    code: 10008,
    status: 404,
    method: 'DELETE',
    url: 'https://discord.com/api/v10/channels/1018438176286724110/messages/1018470209666961408',
    requestBody: { files: undefined, json: undefined }
  }
}

That's a unknown message error you can safely ignore it it's always catched by the exceptions these appears whenever a message is to be edited/deleted but the message doesn't exists not a big deal that's completely random

it spam a lot so it’s som importance

In next pr I'll fix them all this is also included in your #225 Since this isn't a serious issue I am gonna fix this in #225 this is totally random so this can appear on anything

Xenofic · 2022-09-11T14:35:23Z

2022-09-11.18-33-42.mp4
im not any errors in console now but still the same

This seems to be a issue from your side since it works for me and Lukas too so i don't think that still stays a bug or so try to upgrade your node js and check

Xenofic · 2022-09-11T14:36:32Z

@RafCodez if you don't mind can you check if the disconnect issue in #281 is fixed in my repo by using it

PandaIN95 · 2022-09-11T14:42:47Z

@NotAditya69 im using node 16.17.0
for you it is working because you are playing the same song again try changing the song name after disconnect

Xenofic · 2022-09-11T14:48:46Z

Alright I'll try it later currently am not on my pc

Xenofic · 2022-09-12T07:20:29Z

you guys can check now i have pushed the files once again check it, This time it should work i'll also share a video clip from my side

Desktop.2022.09.12.-.12.47.26.01.mp4

@RafCodez @PandaIN95

PandaIN95 · 2022-09-12T07:37:23Z

@NotAditya69 still the same For me
One Suggestion though instead of changing in play you should change the things in playerMove.js event where on bot disconnect it should destroy the player not like bot can't play the new song because of disconnect. The Right Disconnect should work like leave command that's how every bot works

Xenofic · 2022-09-12T07:43:25Z

@NotAditya69 still the same For me One Suggestion though instead of changing in play you should change the things in playerMove.js event where on bot disconnect it should destroy the player not like bot can't play the new song because of disconnect. The Right Disconnect should work like leave command that's how every bot works

how is it not working for you bruh, anyways player move will defo work but i want get new track data you see so either way i will have to reconnect again once disconnected or destroy the player else even if it's connected on the new play execution it won't play anything since erela.js doesn't resume sessions like shoukaku

Xenofic · 2022-09-12T09:43:10Z

@PandaIN95 try now also make sure you have actually pulled the updates from my fork dev branch

PandaIN95 · 2022-09-12T09:49:38Z

@NotAditya69 i fixed it revert all your changes you made for #281

Xenofic · 2022-09-12T09:52:47Z

@NotAditya69 i fixed it revert all your changes you made for #281

but you only seem to destroy the player not resume the old queue? if that was the case should have told me

PandaIN95 · 2022-09-12T09:57:24Z

@NotAditya69 bruhh i never said i want to resume the old queue i said on right click disconnect the player should destroy

Xenofic · 2022-09-12T11:02:00Z

@LucasB25 you can merge this now if you have any other checking to do then feel free

Xenofic added 14 commits September 8, 2022 19:20

added better checks so won't break on loadtypes

a604d58

Added autocompletion support for other search engines

bfeca61

chore: autocompletion support for other search engine and bug fixes

9175836

feat: autocompletion support for other search engines and bug fixes 🐛

f957f09

bug: fixed a bug on autocompletion input being the value

5e40b68

fix: thumbnails and url doesn't display on soundcloud tracks

87bea82

feat: added cheerio dependency to parse html

0afae98

Merge branch 'dev' of https://github.com/NotAditya69/lavamusic into dev

c7c71b1

Update config.js

1be0d17

Signed-off-by: NotAditya <[email protected]>

fix: fixed the bug dataChannel is null

26abfd5

Merge branch 'dev' of https://github.com/NotAditya69/lavamusic into dev

bb0812a

fix: Issue #273 voiceStateUpdate issue

f6e35c0

Delete config.js

90d4beb

Signed-off-by: NotAditya <[email protected]>

Create config.js

73ed246

Signed-off-by: NotAditya <[email protected]>

recommit on #281

6e06a4f

Xenofic added 2 commits September 11, 2022 17:52

ignore: prototype update

a94763b

#281 recommit fix

53742cc

recommit #281

518a155

Xenofic added 2 commits September 12, 2022 15:11

recommit on #281 added new emitter and changed some things

efa9aab

typo

facddc0

more typos

4d74f84

reverted some updates

e639829

LucasB25 mentioned this pull request Sep 12, 2022

buf fix #283

Closed

LucasB25 merged commit 16268a9 into appujet:main Sep 12, 2022

Bug fixes #280

Bug fixes #280

Conversation

Xenofic commented Sep 10, 2022

LucasB25 commented Sep 10, 2022

Xenofic commented Sep 10, 2022

LucasB25 commented Sep 10, 2022

Xenofic commented Sep 10, 2022

LucasB25 commented Sep 10, 2022

LucasB25 commented Sep 10, 2022

Xenofic commented Sep 10, 2022

Xenofic commented Sep 10, 2022

LucasB25 commented Sep 10, 2022 • edited Loading

Xenofic commented Sep 10, 2022

Xenofic commented Sep 10, 2022

LucasB25 commented Sep 10, 2022

Xenofic commented Sep 10, 2022

Xenofic commented Sep 10, 2022

LucasB25 commented Sep 10, 2022

LucasB25 commented Sep 10, 2022

Xenofic commented Sep 11, 2022

Xenofic commented Sep 11, 2022

PandaIN95 commented Sep 11, 2022

Xenofic commented Sep 11, 2022

Xenofic commented Sep 11, 2022

LucasB25 commented Sep 11, 2022

PandaIN95 commented Sep 11, 2022

Xenofic commented Sep 11, 2022

Xenofic commented Sep 11, 2022

Xenofic commented Sep 11, 2022 • edited Loading

PandaIN95 commented Sep 11, 2022

Xenofic commented Sep 11, 2022

Xenofic commented Sep 12, 2022

PandaIN95 commented Sep 12, 2022

Xenofic commented Sep 12, 2022

Xenofic commented Sep 12, 2022

PandaIN95 commented Sep 12, 2022

Xenofic commented Sep 12, 2022

PandaIN95 commented Sep 12, 2022

Xenofic commented Sep 12, 2022

LucasB25 commented Sep 10, 2022 •

edited

Loading

Xenofic commented Sep 11, 2022 •

edited

Loading